Delete records without typing delete

General
1

Hi folks,

I’m still evaluating Gibbon v17 and I came across a little bug.

It’s about deleting a record when typing delete is required, e.g. a user.

To delete a user, one normally must type delete, otherwise it will not go through. Anyway, you can circumvent this by clicking the delete button, then closing the thickbox window, and then clicking the delete button again. Then the record can be deleted without typing delete.

Can you reproduce this in v17?

Kind regards,
Roman

2

Hi Roman,

Interesting, well caught! Yep I was able to reproduce this. I suspect it may be because the confirmation box is just a client-side measure, and something to do with loading the validation through the ajax pagination causes it to only work the first page load. Will take a look and see if there’s a fix.

Thanks!

3

Pushed a fix for v18. The validation library needed the form’s HTML id to be unique in order to load multiple times in the same page, so I’ve added a short random hash to the id value and now it’s working as expected: https://github.com/GibbonEdu/core/commit/bfcfa83149bbf07a7b57712b6136c0481d5f6e6f

Thanks!

4

Hi Sandra,

Thanks for this amazing fast fix! It works for me as well!

Kind regards,
Roman

5

Hi @sandra

I have come across a similar problem.

When deleting a record. If the link is opened in a new tab it allows the deleting of the record or data without having to type delete.

It does not work on all pages. In manage timetable an invalid parameters error appears, which I assume is an error related to not typing delete.

I have managed to replicate the error within manage external assessment

form groups,

departments,

manage users

and year groups.

This is on version 29 that I have been able to replicate this bug.

Regards

NGN

6

Hi @ngn Thanks for the post. The purpose of asking users to type DELETE to confirm deletion is to slow them down and prevent accidental deletion. If a user has gone to the effort to open the delete dialog in a new tab, then they’ve bypassed the confirmation step, but do to so they’ve likely thought about the deletion intentionally.

1 Like
7

Thank you for the clarification.