Time tables with friday and sat switched off

Administration
1

https://photos.google.com/share/AF1QipOLsx9Lz51zt8j8jkHMBcVCQ1LDKZ9DmljWoqM6MtkxibKH7vHzQo474OGTnkDJRA?key=SThsMVNoazlzZmo2VGRPSHV1eGNOUmFaYzBrSWx3

2

Behruz,

I have set my gibbonDaysOfWeek table to have the following values, which causes the days to be reordered in some (most?) places in the system. Unfortunately I just realised, however, that the order of days in the timetable is static, and does not follow the sequence number rules in this table. I will try and write a fix for this in the coming days, and will post an update here in the coming days. I believe the fix will be backwards compatible to v11.

Thanks,

Ross

INSERT INTO gibbonDaysOfWeek (gibbonDaysOfWeekID, name, nameShort, sequenceNumber, schoolDay, schoolOpen, schoolStart, schoolEnd, schoolClose) VALUES
(01, ‘Monday’, ‘Mon’, 2, ‘Y’, ‘07:45:00’, ‘08:30:00’, ‘15:30:00’, ‘17:00:00’),
(02, ‘Tuesday’, ‘Tue’, 3, ‘Y’, ‘07:45:00’, ‘08:30:00’, ‘15:30:00’, ‘17:00:00’),
(03, ‘Wednesday’, ‘Wed’, 4, ‘Y’, ‘07:45:00’, ‘08:30:00’, ‘15:30:00’, ‘17:00:00’),
(04, ‘Thursday’, ‘Thu’, 5, ‘Y’, ‘07:45:00’, ‘08:30:00’, ‘15:30:00’, ‘17:00:00’),
(05, ‘Friday’, ‘Fri’, 6, ‘N’, ‘07:45:00’, ‘08:30:00’, ‘15:30:00’, ‘17:00:00’),
(06, ‘Saturday’, ‘Sat’, 7, ‘N’, NULL, NULL, NULL, NULL),
(07, ‘Sunday’, ‘Sun’, 1, ‘Y’, NULL, NULL, NULL, NULL);

3

Thanks Ross that would be great addition.

4

Dear Ross, I would like to join your team of developers. Please advise.

5

Behruz,

OK, the change has been made, and is backwards compatible with v11. Simple add the files changed in this commit to your system, and it should work, given the database settings above (although you will need to set times for Sunday):

https://github.com/GibbonEdu/core/commit/e48dcf8d378acfb8177974f866e3b710b186a054

I have added an entry to the v12 todo list to include a setting to choose between Monday and Sunday start of week, which will mean no database fiddles. I will update this thread when done.

In terms of becoming a developer (which sounds great), the best option is to sync the v12 branch to your computer, and then run the installer. You can then code, and push to the branch when you have changes.

Thanks,

Ross

6

Ross you are genius. Great

7

Anyway that attendance be taken by Class

8

Behruz,

Genius? No! But I do have a long history of coding PHP, and that experience helps : ) Happy to help.

For your attendance questions, please can you delete it from this thread, and add it as a new thread?

Thanks,

Ross

9


Dear Ross,

You are too humble.
There is still a minor issue with the timetable. In the report available for viewing timetable free space
the order is not maintained and Sunday column is empty?
Regards
Behruz

10

Dear Ross,

Can the size of the boxes in the timetable be increased to accommodate the room too.
Regards,
Behruz

11

Sorry Ross its ok. Did not copy all the files. Thanks

12

No problem. Can you share a screen shot of where you would like room information?

13

Behruz,

Just to let you know, I have implemented an option for setting first day of the week to Sunday (or Monday) in Admin > System Admin, under the Localisation section of System Settings. It is in the v12 dev commit shown below, but it is NOT backwards compatible with v11.

https://github.com/GibbonEdu/core/commit/968a251fe31f30a722a75fdf0525f5dcd9bf7666

Thanks,

Ross

14

I made the change to Sunday but calendar picker still starts on Monday?

Thanks

Behruz,

Just to let you know, I have implemented an option for setting first day of the week to Sunday (or Monday) in Admin > System Admin, under the Localisation section of System Settings. It is in the v12 dev commit shown below, but it is NOT backwards compatible with v11.

https://github.com/GibbonEdu/core/commit/968a251fe31f30a722a75fdf0525f5dcd9bf7666

Thanks,

Ross

15

@ross please could you take a look a this? Looks like it might be a bug…thanks!

16

Hmm, looks like the jQuery date picker has been using the locale to determine the first day of the week. I’ve updated it to honour the system setting regardless of the locale. The commit has been applied to the v21 development branch here: https://github.com/GibbonEdu/core/commit/b252df00f739a9ab215c6c370c93fc737ab987a3 It’s a small tweak, if you wanted you could apply the same change back to your system by changing the lines indicated in the commit.

17
Hmm, looks like the jQuery date picker has been using the locale to determine the first day of the week. I've updated it to honour the system setting regardless of the locale. The commit has been applied to the v21 development branch here: https://github.com/GibbonEdu/core/commit/b252df00f739a9ab215c6c370c93fc737ab987a3 It's a small tweak, if you wanted you could apply the same change back to your system by changing the lines indicated in the commit.

Made the changes to index.php and resources/assets/js/setup.js but first day is still Monday. Thanks

18

Your javascript may be cached client-side, perhaps try clearing your cache or shift-refreshing the page.